create pubsub topic on startup if it doesn't exists #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agbpatro
force-pushed
the
create_topic_if_doesnt_exist_startup
branch
from
69e5e04 to
a3a0934
Compare
9 tasks
agbpatro
force-pushed
the
create_topic_if_doesnt_exist_startup
branch
2 times, most recently
from
5246522 to
39c902f
Compare
aaronpkahn
reviewed
Jan 6, 2025
README.md
Outdated
| @@ -156,6 +156,7 @@ Dispatchers handle vehicle data processing upon its arrival at Fleet Telemetry s | |||
| * Configure stream names directly by setting the streams config `"kinesis": { "streams": { *topic_name*: stream_name } }` | |||
| * Override stream names with env variables: KINESIS_STREAM_\*uppercase topic\* ex.: `KINESIS_STREAM_V` | |||
| * Google pubsub: Along with the required pubsub config (See ./test/integration/config.json for example), be sure to set the environment variable `GOOGLE_APPLICATION_CREDENTIALS` | |||
| * Fleet Telemetry server will try to create topics on startup. If it topic doesn't exists or creation of topic fails, server will fail to startup and crash. | |||
There was a problem hiding this comment.
Shorter option: On startup, the server will attempt to create missing topics and panic on failure.
aaronpkahn
approved these changes
Jan 6, 2025
agbpatro
force-pushed
the
create_topic_if_doesnt_exist_startup
branch
from
39c902f to
1ac90e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (#289)
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: